Skip to content

Always call new DoubleBufferedEPOutHandler on reconnect #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

facchinm
Copy link
Member

Avoid memory leak by deleting the buffers; DoubleBufferedEPOutHandler should be refactored (in beta branch) to allow separate "new" and "setup" procedures

Fixes #350

Avoid memory leak by deleting the buffers; DoubleBufferedEPOutHandler should be refactored (in beta branch) to allow separate "new" and "setup" procedures

Fixes arduino#350
@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b197_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Always call new DoubleBufferedEPOutHandler on reconnect #352
  5. Select one of the boards under SAMD Pull Request Always call new DoubleBufferedEPOutHandler on reconnect #352 in Tools->Board menu
  6. Compile/Upload as usual

@Sulymarco
Copy link

Hi @facchinm ,
thanks for your quick response.
I tested your fix and I can confirm that it works and solve the issue #350 .

Thanks again
Marco.

@facchinm facchinm merged commit 691b288 into arduino:master Aug 28, 2018
@crgallac
Copy link

Thanks @facchinm ,
This update fixed my issue with issue #350 too.
All the best,
Colin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants